Skip to content

data-component adr part 2#7776

Open
llastflowers wants to merge 50 commits into
mainfrom
llastflowers/6497/data-component-ADR-part-2
Open

data-component adr part 2#7776
llastflowers wants to merge 50 commits into
mainfrom
llastflowers/6497/data-component-ADR-part-2

Conversation

@llastflowers
Copy link
Copy Markdown
Contributor

@llastflowers llastflowers commented Apr 23, 2026 •
edited
Loading

Relates to https://github.com/github/primer/issues/6497

Changelog

New

Add data-component attributes and associated tests for Blankslate, BranchName, Breadcrumbs, ButtonGroup, Checkbox, CheckboxGroup, CircleBadge, ConfirmationDialog, CounterLabel, and Dialog.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 2b1aa01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 23, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 April 23, 2026 21:21 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 April 23, 2026 21:58 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 April 23, 2026 23:29 Inactive
@github-actions github-actions Bot requested a deployment to storybook-preview-7776 April 23, 2026 23:45 Abandoned
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 May 6, 2026 23:30 Inactive
@llastflowers llastflowers changed the title Llastflowers/6497/data component adr part 2 data-component adr part 2 May 7, 2026
francinelucca
francinelucca requested changes May 7, 2026
View reviewed changes
Comment thread packages/react/src/Breadcrumbs/Breadcrumbs.tsx
Comment thread packages/react/src/Breadcrumbs/Breadcrumbs.tsx
Comment thread packages/react/src/CheckboxGroup/CheckboxGroup.tsx
Comment thread packages/react/src/Checkbox/Checkbox.tsx
Comment thread packages/react/src/CounterLabel/CounterLabel.tsx
Comment thread packages/react/src/Dialog/Dialog.tsx Outdated
Comment thread packages/react/src/Dialog/Dialog.tsx Outdated
Comment thread packages/react/src/Dialog/Dialog.tsx
Comment thread packages/react/src/Dialog/Dialog.test.tsx
@llastflowers llastflowers requested a review from francinelucca May 8, 2026 17:43
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 May 8, 2026 17:47 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 May 8, 2026 17:57 Inactive
francinelucca
francinelucca requested changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment and some previous ones still need to be addressed 🙏🏽

Comment thread packages/react/src/Dialog/Dialog.tsx Outdated
@llastflowers
update Breadcrumbs to add data-component to Breadcrumbs.MenuItem, add…
02c4a6f 
… a next test, and move the location of the data-component in Dialog on FooterButton
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 May 11, 2026 19:52 Inactive
@llastflowers
add capability to pass data-component for CheckboxGroup sub-component…
627cada 
…s through parents, add new tests, and updateInputValidation to allow data-component=CheckboxGroup.Validation to pass through
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 May 11, 2026 20:46 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7776 May 11, 2026 21:31 Inactive
@llastflowers llastflowers added Canary Release Apply this label when you want CI to create a canary release of the current PR and removed Canary Release Apply this label when you want CI to create a canary release of the current PR labels May 11, 2026
@primer-integration
Copy link
Copy Markdown

primer-integration Bot commented May 11, 2026

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/20436

@primer-integration
Copy link
Copy Markdown

primer-integration Bot commented May 11, 2026

Integration test results from github/github-ui:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jonrohan jonrohan jonrohan approved these changes

@francinelucca francinelucca Awaiting requested review from francinelucca

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Canary Release Apply this label when you want CI to create a canary release of the current PR integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@llastflowers @jonrohan @francinelucca